fix(select): give native select a bigger clickable area #13228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Sep 20, 2018
|
Hi @vivian-hu! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
|
Hi @vivian-hu! This PR has merge conflicts due to recent upstream merges. |
|
@vivian-hu can you rebase? This passes presubmit |
vivian-hu-zz
force-pushed
the
selectClickArea
branch
from
5826025 to
128ff5d
Compare
mmalerba
reviewed
Sep 27, 2018
vivian-hu-zz
force-pushed
the
selectClickArea
branch
from
128ff5d to
85179e3
Compare
mmalerba
approved these changes
Sep 27, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add padding to let select catch the click in bigger area; move the select up to let the padding overlap with the existing label so they look the same. Give it a negative margin so the item below can move up.