Skip to content

Conversation

devversion
Copy link
Member

@devversion devversion commented Sep 22, 2018

  • Since people often click on the ripple container of the example, we need to disable the user selection because otherwise the text will be accidentally selected.

  • Disables the no-prefixes rule for example style files. The examples are not auto-prefixed and we don't want to show the /** stylelint-disable comments in the examples.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 22, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 22, 2018
* Since people often click on the ripple container of the example, we need to disable the user selection because otherwise the text will be accidentally selected.

* Disables the `no-prefixes` rule for example style files. The examples are not auto-prefixed and we don't want to show the `/** stylelint-disable` comments in the examples.
@devversion devversion force-pushed the chore/exampls-ripple-user-select branch from ca558b2 to d5bce56 Compare September 22, 2018 13:03
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 22, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 70dd33f into angular:master Sep 25, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
…lar#13257)

* Since people often click on the ripple container of the example, we need to disable the user selection because otherwise the text will be accidentally selected.
* Disables the `no-prefixes` rule for example style files. The examples are not auto-prefixed and we don't want to show the `/** stylelint-disable` comments in the examples.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants