Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio): clear tabindex from host element #13323

Merged
merged 1 commit into from
Sep 27, 2018
Merged

fix(radio): clear tabindex from host element #13323

merged 1 commit into from
Sep 27, 2018

Conversation

crisbeto
Copy link
Member

Along the same lines as #13311 and #13308. Clears the tabindex from the radio button host element so we don't end up with multiple tab stops.

@crisbeto
fix(radio): clear tabindex from host element
50e3677 
Along the same lines as angular#13311 and angular#13308. Clears the `tabindex` from the radio button host element so we don't end up with multiple tab stops.
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Sep 26, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 26, 2018
jelbourn
jelbourn approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 26, 2018
@jelbourn jelbourn merged commit 5c0a061 into angular:master Sep 27, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@crisbeto @roboshoes
fix(radio): clear tabindex from host element (angular#13323)
005e13d 
Along the same lines as angular#13311 and angular#13308. Clears the `tabindex` from the radio button host element so we don't end up with multiple tab stops.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 3, 2018
@crisbeto
fix(radio): host element unable to receive focus events
e91f0a1 
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes angular#13953.
@crisbeto crisbeto mentioned this pull request Nov 3, 2018
Merged
vivian-hu-zz pushed a commit that referenced this pull request Nov 6, 2018
@crisbeto
fix(radio): host element unable to receive focus events
f50c945 
In #13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes #13953.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 9, 2018
@crisbeto
fix(radio): host element unable to receive focus events
3cf228d 
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes angular#13953.
mmalerba pushed a commit that referenced this pull request Dec 7, 2018
@crisbeto @mmalerba
fix(radio): host element unable to receive focus events (#13956)
41eb27e 
In #13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes #13953.
mmalerba pushed a commit that referenced this pull request Dec 10, 2018
@crisbeto @mmalerba
fix(radio): host element unable to receive focus events (#13956)
097ef6c 
In #13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes #13953.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 11, 2018
@crisbeto
fix(radio): host element unable to receive focus events
6069747 
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes angular#13953.
@crisbeto crisbeto mentioned this pull request Dec 11, 2018
Merged
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 13, 2018
@crisbeto
fix(radio): host element unable to receive focus events
503c0c2 
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes angular#13953.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 17, 2018
@crisbeto
fix(radio): host element unable to receive focus events
ba8f893 
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes angular#13953.
jelbourn pushed a commit that referenced this pull request Dec 20, 2018
@crisbeto @jelbourn
fix(radio): host element unable to receive focus events (#14472)
8c35917 
In #13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes #13953.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@crisbeto @josephperrott
fix(radio): host element unable to receive focus events (angular#13956)
26d8df2 
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes angular#13953.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@crisbeto @josephperrott
fix(radio): host element unable to receive focus events (angular#14472)
68cf741 
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes angular#13953.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @googlebot