Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): host element unable to receive focus events #14472

Merged

Conversation

crisbeto
Copy link
Member

In #13323 we started clearing the tabindex from the host element in order to avoid having two elements with the same tabindex when the consumer sets a custom tabindex. As a result, the mat-radio-button can no longer receive focus and forward it to the input. These changes always reset the tabindex to -1 so the element is focusable, but not tabbable.

Fixes #13953.

Note: this is a resubmit of #13956.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 11, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 11, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Dec 11, 2018
@mmalerba
Copy link
Contributor

Caretaker note: causes a handful of failures in g3 due to assertions about tabindex that are no longer true

@ngbot
Copy link

ngbot bot commented Dec 11, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: e2e_tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto force-pushed the 13953/radio-non-focusable-resubmit branch from 6069747 to 503c0c2 Compare December 13, 2018 17:49
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes angular#13953.
@crisbeto crisbeto force-pushed the 13953/radio-non-focusable-resubmit branch from 503c0c2 to ba8f893 Compare December 17, 2018 21:55
@jelbourn jelbourn merged commit 8c35917 into angular:master Dec 20, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
In angular#13323 we started clearing the `tabindex` from the `host` element in order to avoid having two elements with the same `tabindex` when the consumer sets a custom `tabindex`. As a result, the `mat-radio-button` can no longer receive focus and forward it to the `input`. These changes always reset the `tabindex` to -1 so the element is focusable, but not tabbable.

Fixes angular#13953.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus redirection does not work for mat-radio-button
4 participants