Skip to content

feat(range-slider): Add range-slider (double-slider) functionality slider component #13324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

PhilippS93
Copy link

  • Added range slider "two thumb" like shown in the material spec

  • Added demo in the material demo-app.

sliders

See: #1331

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Sep 26, 2018
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Sep 26, 2018
@ngbot
Copy link

ngbot bot commented Sep 27, 2018

Hi @PhilippS93! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@Journeycorner
Copy link

Any news on when this is going to land? Otherwise I need to hack a solution for ssr.

@MaximilianGraef
Copy link

Iam looking forward to this for ages. Please let it happen :)

@jelbourn
Copy link
Member

Hey there- we really appreciate the enthusiasm for this feature. For the time being, we aren't going to add this to the mat-slider. While we know a many people want this feature, this is countered by:

  • Range sliders aren't captured in the Material Design spec; we don't want to open up an interaction pattern to Google applications that the Material Design UX team doesn't approve of.
  • We're working on a way to share some code with the Material Design team (MDC web), and they also don't support range sliders.
  • Any implementation would have to have a solid a11y interaction pattern for screen-reader users. This would require a bit more work, since it would mean that a range slider would likely have to present itself as multiple role="range" elements.

We definitely encourage you to share your work as a standalone component, though!

@jelbourn jelbourn closed this Oct 26, 2018
@Journeycorner
Copy link

@jelbourm There is a range slider shown on the official material page, how can it be not in the spec? https://material.io/design/components/sliders.html#

@jelbourn
Copy link
Member

Huh, I hadn't noticed that one image before. It's strange that exists there but isn't mentioned anywhere else on the page. I'll check with the Material Design UX team to see if it's intentional.

@jelbourn jelbourn reopened this Oct 26, 2018
@jelbourn
Copy link
Member

jelbourn commented Nov 6, 2018

Following up: talking to someone from the Material Design team, they say that that one image in the spec really shouldn't be in there since the range slider isn't otherwise specified. There's an open bug now to remove it.

@odahcam
Copy link
Contributor

odahcam commented Nov 8, 2018

Material Design spec always had range slider images but no text about it and no design alternatives for it. It would be nice to give us some alternative to range sliders if they aren't a good UI component. @jelbourn are currently there any components in this lib we can use as an alternative to range sliders?

I'm very excited to know that some code sharing with MDC web can happen.

@odahcam odahcam mentioned this pull request Nov 9, 2018
@drenda
Copy link

drenda commented Nov 29, 2018

Hi guys, any news about this new function?

@djtahl
Copy link

djtahl commented Dec 10, 2018

Hello guys, is there a way to access this "open bug" in Material Design project and have more visibility on wether there is a possibility to add the specs someday for such iteration on the slider component ?
We also need this type of slider with double inputs.

@AndreasDeNeve
Copy link

Any timeline available for resolving the merge conflicts + PR review?

@manuelarte
Copy link

really looking forward to this feature

@odahcam
Copy link
Contributor

odahcam commented Jan 4, 2019

Anyone knows something about a standalone component compatible with Angular Material?

@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@vieira83
Copy link

vieira83 commented May 20, 2019

Any updates on when this new function will be merged and added to the slider?

@preda7or
Copy link

preda7or commented Jun 3, 2020

Now that Flutter has double thumb slider too. Could we revive this PR?

@mmalerba mmalerba added area: material/slider material spec Issue related to the Material Design spec https://material.io/design/ and removed area: material/slider material spec Issue related to the Material Design spec https://material.io/design/ labels Jun 3, 2020
@mmalerba
Copy link
Contributor

mmalerba commented Jun 3, 2020

The MDC team does plan to build a slider with multiple thumbs, and we plan to build one based on that once its done

@mohitvirli
Copy link

Any updates on this PR (looks stale) or is there another one tracking this? Thanks.

@jelbourn
Copy link
Member

jelbourn commented Oct 1, 2020

Closing this since we don't plan on adding range functionality to the current MatSlider. We will be making a new slider based on top of MDC Web's slider, which does already support range.

@jelbourn jelbourn closed this Oct 1, 2020
@odahcam
Copy link
Contributor

odahcam commented Oct 6, 2020

Is there a ETA or roadmap for the new slider?

@jelbourn
Copy link
Member

jelbourn commented Oct 7, 2020

No ETA, but the MDC versions of the components are the team's main priority

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.