Skip to content

docs(schematics): add drawing for CDK shared logic #13394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2018
Merged

docs(schematics): add drawing for CDK shared logic #13394

merged 1 commit into from
Oct 3, 2018

Conversation

devversion
Copy link
Member

  • Adds a drawing which has been created before implementing the shared schematic logic with the CDK. This drawing should be in the repository because it avoids recurring questions about the CLI workflow.

@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Oct 2, 2018
@devversion devversion requested a review from amcdnl as a code owner October 2, 2018 19:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 2, 2018
@jelbourn
Copy link
Member

jelbourn commented Oct 2, 2018

Can you run pngcrush on this image? It reduces the size by 25%

Also the commit type is really docs

@devversion
docs(schematics): add drawing for CDK shared logic
14c22f4 
* Adds a drawing which has been created before implementing the shared schematic logic with the CDK. This drawing should be in the repository because it avoids recurring questions about the CLI workflow.
@devversion devversion force-pushed the chore/schematics-shared-logic-png branch from cdf76be to 14c22f4 Compare October 2, 2018 21:51
@devversion devversion changed the title refactor(schematics): add drawing for CDK shared logic docs(schematics): add drawing for CDK shared logic Oct 2, 2018
@devversion
Copy link
Member Author

Done. Saved about 80KB.

jelbourn
jelbourn approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 2, 2018
@vivian-hu-zz vivian-hu-zz merged commit f91c0b7 into angular:master Oct 3, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@devversion @roboshoes
docs(schematics): add drawing for CDK shared logic (angular#13394)
bd12425 
* Adds a drawing which has been created before implementing the shared schematic logic with the CDK. This drawing should be in the repository because it avoids recurring questions about the CLI workflow.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @vivian-hu-zz