Skip to content

fix(virtual-scroll): don't set both right and left on the content wrapper #13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

fix(virtual-scroll): don't set both right and left on the content wrapper #13412

merged 1 commit into from
Oct 4, 2018

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Oct 3, 2018

Otherwise it prevents the horizontal scrollbar from showing when
contain: content is used. Fixes #13231

@mmalerba
fix(virtual-scroll): don't set both right and left on the content
a6bb869 
wrapper

Otherwise it prevents the horizontal scrollbar from showing when
`contain: content` is used. Fixes angular#13231
@mmalerba mmalerba added the P2 The issue is important to a large percentage of users, with a workaround label Oct 3, 2018
@mmalerba mmalerba requested a review from jelbourn October 3, 2018 19:24
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 3, 2018
crisbeto
crisbeto approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 3, 2018
jelbourn
jelbourn approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added the target: major This PR is targeted for the next major release label Oct 4, 2018
@vivian-hu-zz vivian-hu-zz merged commit 6ee9149 into angular:master Oct 4, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@mmalerba @roboshoes
fix(virtual-scroll): don't set both right and left on the content (…
b540eb5 
…angular#13412)

wrapper

Otherwise it prevents the horizontal scrollbar from showing when
`contain: content` is used. Fixes angular#13231
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Virtual scroll does not show horizontal scrollbar in vertical mode.
6 participants
@mmalerba @jelbourn @crisbeto @googlebot @josephperrott @vivian-hu-zz