build: run chrome and firefox headless tests in circleci #13603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/run-tests-on-circle
branch
4 times, most recently
from
4cfc804 to
d1be4aa
Compare
devversion
added
blocked
jelbourn
reviewed
Oct 15, 2018
| tests_local_browsers: | ||
| docker: | ||
| # TODO(devversion): Temporarily use a image that includes Firefox 62 because the | ||
| # ngcontainer image does include an old Firefox version that does not support headless. |
There was a problem hiding this comment.
Did you / can you file an issue for this and reference it here?
There was a problem hiding this comment.
I actually filed a PR and chatted with Alex about it. Added the URL of the PR to the comment
|
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
* Moves the `travis_required` TravisCI job to CircleCI. Our `ngcontainer` image already comes with Chrome and Firefox installed.
devversion
force-pushed
the
build/run-tests-on-circle
branch
from
8b160cc to
1b12618
Compare
devversion
removed
the
blocked
jelbourn
added
pr: lgtm
action: merge
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
travis_requiredTravisCI job to CircleCI.Related
ngcontainerPR: angular/angular#26435. This is not blocking us, since we usecircleci/node-10.20-browsersto be able to use Firefox headless.PR based and blocked on: #13596