chore(drag-drop): rename cdkDrop to cdkDropList #13619
Conversation
josephperrott
added
the
target: major
googlebot
added
the
cla: yes
josephperrott
changed the title
| providers: [ | ||
| {provide: CDK_DROP_CONTAINER, useExisting: CdkDrop}, |
There was a problem hiding this comment.
We should probably rename CDK_DROP_CONTAINER to CDK_DROP_LIST. Same goes for the CdkDropContainer interface.
There was a problem hiding this comment.
Should it be CDK_DROP_LIST_CONTAINER? It's a bit long but I think its okay for this usage.
There was a problem hiding this comment.
Yeah that works too. Since this is a private thing the length doesn't matter too much.
There was a problem hiding this comment.
any documentation on how to use CDK_DROP_LIST ?
| @@ -1,3 +1,3 @@ | |||
| <div cdkDrop cdkDropOrientation="horizontal" class="example-list" (cdkDropDropped)="drop($event)"> | |||
| <div cdkDropList cdkDropOrientation="horizontal" class="example-list" (cdkDropListDropped)="drop($event)"> | |||
There was a problem hiding this comment.
cdkDropOrientation should also be renamed to cdkDropListOrientation
Fixes some invalid leftover references to `cdkDrop` after angular#13619.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.