Skip to content

build: run e2e tests on circlci #13643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

No description provided.

@devversion devversion requested a review from jelbourn as a code owner October 17, 2018 12:03
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 17, 2018
@devversion devversion force-pushed the build/run-e2e-tests-circleci branch from cabbb37 to 37362d7 Compare October 17, 2018 12:10
@devversion devversion force-pushed the build/run-e2e-tests-circleci branch from 37362d7 to ac38cdb Compare October 17, 2018 12:11
@devversion
Copy link
Member Author

@jelbourn 15min to 4min 🎉 Better CI resources (CPU, RAM) + better caching + more parallel instances. And probably Travis' chrome addon also provided a older Chrome version.

@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Oct 17, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 17, 2018
@josephperrott josephperrott merged commit 7b6e90e into angular:master Oct 17, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants