Skip to content

fix(progress-bar): account for query params when prefixing references #13942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

fix(progress-bar): account for query params when prefixing references #13942

merged 1 commit into from
Nov 7, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 2, 2018

Fixes the progress bar not accounting for URL query params when it prefixes its SVG references.

Related to #13930.

@crisbeto
fix(progress-bar): account for query params when prefixing references
4c6f267 
Fixes the progress bar not accounting for URL query params when it prefixes its SVG references.

Related to angular#13930.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 2, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 2, 2018
josephperrott
josephperrott approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 2, 2018
jelbourn
jelbourn approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivian-hu-zz vivian-hu-zz merged commit 2290063 into angular:master Nov 7, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@crisbeto
fix(progress-bar): account for query params when prefixing references (…
eb82847 
…#13942)

Fixes the progress bar not accounting for URL query params when it prefixes its SVG references.

Related to #13930.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @josephperrott @googlebot @vivian-hu-zz