-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(checkbox): poor color contrast for disabled checkbox #14044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though we'll see how the screenshots go
@@ -73,7 +74,7 @@ | |||
} | |||
|
|||
.mat-checkbox-label { | |||
color: $disabled-color; | |||
color: mat-color($foreground, disabled-text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that the contrast of disabled-text
in dark themes doesn't meet a11y standards.
We should use secondary-text
here for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Fixes some poor color contrast on the text of a disabled checkbox. The issue comes from the fact that it was using a custom color rather than the one from theme.
acea693
to
81f1911
Compare
Fixes some poor color contrast on the text of a disabled checkbox. The issue comes from the fact that it was using a custom color rather than the one from theme.
Fixes some poor color contrast on the text of a disabled checkbox. The issue comes from the fact that it was using a custom color rather than the one from theme.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes some poor color contrast on the text of a disabled checkbox. The issue comes from the fact that it was using a custom color rather than the one from theme.
For reference (top one is what we have in master):