chore(option): use the top level font-family value from config for mat-option font-family #14072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
the
target: patch
googlebot
added
the
cla: yes
josephperrott
force-pushed
the
mat-option-family-change
branch
from
02c79b5 to
e2e4c59
Compare
crisbeto
reviewed
Nov 9, 2018
| @@ -48,7 +48,7 @@ | |||
| @mixin mat-option-typography($config) { | |||
| .mat-option { | |||
| font: { | |||
| family: mat-font-family($config, subheading-2); | |||
| font-family: mat-font-family($config); | |||
There was a problem hiding this comment.
This will produce font-font-family: <value> when transpiled.
josephperrott
force-pushed
the
mat-option-family-change
branch
from
e2e4c59 to
1932177
Compare
josephperrott
added
P2
jelbourn
added
pr: lgtm
action: merge
…t-option font-family
josephperrott
force-pushed
the
mat-option-family-change
branch
from
1932177 to
5a08268
Compare
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
…t-option font-family (#14072)
josephperrott
added a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…t-option font-family (angular#14072)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.