fix(form-field): error when native select has no options #14102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an error being thrown when there's a native `select` without any options inside a `mat-form-field`. Fixes angular#14101.
googlebot
added
the
cla: yes
mmalerba
approved these changes
Nov 12, 2018
mmalerba
added
pr: lgtm
action: merge
|
Not to be a bother, but could someone merge these changes? There is a fix in this PR that will hopefully fix a breaking bug in my app. If there are some restrictions on why is hasn't been done yet, is there a nightly build with this fix implemented? |
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
Fixes an error being thrown when there's a native `select` without any options inside a `mat-form-field`. Fixes #14101.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
Fixes an error being thrown when there's a native `select` without any options inside a `mat-form-field`. Fixes angular#14101.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error being thrown when there's a native
selectwithout any options inside amat-form-field.Fixes #14101.