build: throw when running build tasks inside of a directory with spaces #14126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently building Angular Material with gulp inside of directories that include spaces, does not work because `child_process.spawnSync` does not properly treat the whole path as binary and just considers everything after the first space as command line argument. We can fix these issues by ensuring that the binary is always located in the working directory. Also we would need to make sure that we wrap all `child_process` arguments with explict quotes because otherwise NodeJS would treat them as individual arguments (e.g. `path/to/my project/ -> ["path/to/my", "project"]) -- **TL;DR**: As this is just too much work for something we will eventually replace with Bazel, we are just printing an error message.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
Nov 19, 2018
…es (#14126) Currently building Angular Material with gulp inside of directories that include spaces, does not work because `child_process.spawnSync` does not properly treat the whole path as binary and just considers everything after the first space as command line argument. We can fix these issues by ensuring that the binary is always located in the working directory. Also we would need to make sure that we wrap all `child_process` arguments with explict quotes because otherwise NodeJS would treat them as individual arguments (e.g. `path/to/my project/ -> ["path/to/my", "project"]) -- **TL;DR**: As this is just too much work for something we will eventually replace with Bazel, we are just printing an error message.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently building Angular Material with gulp inside of directories that include spaces, does not work because
child_process.spawnSyncdoes not properly treat the whole path as binary and just considers everything after the first space as command line argument.We can fix these issues by ensuring that the binary is always located in the working directory. Also we would need to make sure that we wrap all
child_processarguments with explict quotes because otherwise NodeJS would treat them as individual arguments (e.g. `path/to/my project/ -> ["path/to/my", "project"])--
TL;DR: As this is just too much work for something we will eventually replace with Bazel, we are just printing an error message.
Closes #13871