build: validate CDK public API using ts-api-guardian #14131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
added
the
blocked
devversion
removed
the
blocked
devversion
force-pushed
the
build/validate-cdk-public-api-guard
branch
from
a6cd21f to
8f2745c
Compare
jelbourn
approved these changes
Nov 14, 2018
| # For example: "public_api_guard/cdk/cdk.d.ts" will be the golden for the primary entry-point. | ||
| entry_point_path = "%s" % (package_name if entry_point == package_name | ||
| else "%s/%s" % (package_name, entry_point)) | ||
|
|
There was a problem hiding this comment.
Fantastic commenting in this file.
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
Nov 19, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is just the CDK for now. Material will be a follow-up because I assume there will be some more issues in regards to aliases which are not supported by
ts-api-guardian.Also there are currently a few minor warnings about re-exports from other packages. I need to figure out how we can fix those because in Material its quite common to re-export stuff from another package.