Skip to content

Conversation

crisbeto
Copy link
Member

Makes it easier to disable dragging under an entire group of drop lists.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Nov 16, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 16, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 16, 2018
@ngbot
Copy link

ngbot bot commented Nov 16, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: bazel_build_test" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott removed the action: merge The PR is ready for merge by the caretaker label Nov 19, 2018
@crisbeto crisbeto force-pushed the drop-list-group-disabled branch from b56aa0f to 6110525 Compare December 6, 2018 20:39
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 6, 2018
@crisbeto crisbeto force-pushed the drop-list-group-disabled branch from 6110525 to ef55e72 Compare December 9, 2018 09:45
@crisbeto crisbeto requested a review from devversion as a code owner December 9, 2018 09:45
Makes it easier to disable dragging under an entire group of drop lists.
@vivian-hu-zz vivian-hu-zz merged commit 94e76de into angular:master Dec 12, 2018
vivian-hu-zz added a commit that referenced this pull request Dec 13, 2018
vivian-hu-zz added a commit that referenced this pull request Dec 13, 2018
…correctly if the floating label is disabled" (#14505)

* Revert "Revert "fix(snack-bar): announcing same message twice to screen readers" (#14494)"

This reverts commit e9466a4.

* Revert "Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes" (#14492)"

This reverts commit 3eb7e9c.

* Revert "Revert "fix(menu): allow text wrapping in menu items" (#14493)"

This reverts commit a3da8d2.

* Revert "build: update nodejs bazel rules (#14466)"

This reverts commit a3fef46.

* Revert "docs(form-field): native select reset values not working in examples (#14236)"

This reverts commit 97f52c0.

* Revert "fix(menu): allow text wrapping in menu items (#11430)"

This reverts commit 3661abe.

* Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes (#13065)"

This reverts commit fe96f38.

* Revert "build: replace deprecated tslint rule with compiler option (#13186)"

This reverts commit 5dfa45f.

* Revert "fix(snack-bar): announcing same message twice to screen readers (#13298)"

This reverts commit 3fb4b23.

* Revert "feat(drag-drop): allow entire group of drop lists to be disabled (#14179)"

This reverts commit 94e76de.

* Revert "fix(drag-drop): prevent text selection while dragging on Safari (#14405)"

This reverts commit 220e388.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#14414)"

This reverts commit 53d2b58.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…ular#14179)

Makes it easier to disable dragging under an entire group of drop lists.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…correctly if the floating label is disabled" (angular#14505)

* Revert "Revert "fix(snack-bar): announcing same message twice to screen readers" (angular#14494)"

This reverts commit e9466a4.

* Revert "Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes" (angular#14492)"

This reverts commit 3eb7e9c.

* Revert "Revert "fix(menu): allow text wrapping in menu items" (angular#14493)"

This reverts commit a3da8d2.

* Revert "build: update nodejs bazel rules (angular#14466)"

This reverts commit a3fef46.

* Revert "docs(form-field): native select reset values not working in examples (angular#14236)"

This reverts commit 97f52c0.

* Revert "fix(menu): allow text wrapping in menu items (angular#11430)"

This reverts commit 3661abe.

* Revert "fix(dialog,bottom-sheet): invert backdrop color on dark themes (angular#13065)"

This reverts commit fe96f38.

* Revert "build: replace deprecated tslint rule with compiler option (angular#13186)"

This reverts commit 5dfa45f.

* Revert "fix(snack-bar): announcing same message twice to screen readers (angular#13298)"

This reverts commit 3fb4b23.

* Revert "feat(drag-drop): allow entire group of drop lists to be disabled (angular#14179)"

This reverts commit 94e76de.

* Revert "fix(drag-drop): prevent text selection while dragging on Safari (angular#14405)"

This reverts commit 220e388.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (angular#14414)"

This reverts commit 53d2b58.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants