Skip to content

Conversation

devversion
Copy link
Member

  • Updates the TypeScript bazel rules to the latest version that includes a hotfix for emit diagnostics not being reported. Also it includes bazelbuild/rules_typescript@f9d6edb which is necessary to build the src:module-typings on Windows w/ ng_package.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 11, 2018
@devversion devversion requested a review from jelbourn as a code owner December 11, 2018 17:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 11, 2018
@devversion devversion force-pushed the build/update-typescript-bazel-rule branch from b13a6f8 to 4aa18c0 Compare December 11, 2018 17:03
@devversion devversion added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Dec 11, 2018
@devversion
Copy link
Member Author

devversion commented Dec 11, 2018

Blocked until there is a new Angular patch release.. Our current Angular version requires v0.21.0.

* Updates the TypeScript bazel rules to the latest version that includes a hotfix for emit diagnostics not being reported. Also it includes bazelbuild/rules_typescript@f9d6edb which is necessary to build the `src:module-typings` on Windows w/ ng_package.
@devversion devversion force-pushed the build/update-typescript-bazel-rule branch 2 times, most recently from 218ec70 to ca81bd8 Compare December 12, 2018 20:13
@devversion devversion force-pushed the build/update-typescript-bazel-rule branch from ca81bd8 to 89d3e6e Compare December 12, 2018 20:47
@devversion devversion requested a review from mmalerba as a code owner December 12, 2018 20:47
@devversion devversion removed the blocked This issue is blocked by some external factor, such as a prerequisite PR label Dec 12, 2018
@devversion
Copy link
Member Author

This one is no longer blocked and also includes various TS fixes that weren't detected because of rules_typescript not reporting diagnostics.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 13, 2018
@vivian-hu-zz vivian-hu-zz merged commit e44cc52 into angular:master Dec 14, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
* build: update typescript bazel rules

* Updates the TypeScript bazel rules to the latest version that includes a hotfix for emit diagnostics not being reported. Also it includes bazelbuild/rules_typescript@f9d6edb which is necessary to build the `src:module-typings` on Windows w/ ng_package.

* Update to Angular 7.1.3
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants