Skip to content

Conversation

devversion
Copy link
Member

No description provided.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 13, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2018
# it's own entry-point. TODO(devversion): Support sub API docs for entry-points
if package_name == "material":
expected_outputs += [
ctx.actions.declare_file("%s/%s-%s.html" % (output_dir_name, package_name, "ripple"))
Copy link
Member Author

@devversion devversion Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelbourn I didn't bother too much about it (yet), because I want to get this going now. I will follow-up on this later as a low priority.

@devversion devversion added needs: discussion Further discussion with the team is needed before proceeding in progress This issue is currently in progress and removed in progress This issue is currently in progress needs: discussion Further discussion with the team is needed before proceeding labels Dec 13, 2018
@devversion devversion force-pushed the build/package-material-api-docs-npm-package branch from 8825bfd to 4339219 Compare December 21, 2018 16:55
@devversion
Copy link
Member Author

@jelbourn This would be ready for review. I have some plans to reduce the Bazel arguments overhead, but I want to address this in a follow-up if that's okay.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 21, 2018
@jelbourn jelbourn merged commit d22f48c into angular:master Dec 21, 2018
@devversion devversion deleted the build/package-material-api-docs-npm-package branch December 23, 2018 12:05
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants