build: dev app not picking up typography changes #14611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
reviewed
Dec 22, 2018
tools/gulp/tasks/development.ts
Outdated
| join(materialPackage.sourceDir, '**/!(*-theme.scss)'), `!${materialCoreThemingGlob}` | ||
| ], ['material:build-no-bundles']); | ||
| // Note that we need to rebuild the dev app CSS, because the typography may have changed. | ||
| ], ['material:build-no-bundles', ':build:devapp:scss']); |
There was a problem hiding this comment.
Can the typography also change for JS files?
Otherwise we should just add it to the watcher below?
There was a problem hiding this comment.
No it shouldn't. I got it working a bit cleaner by updating the glob instead.
Fixes the dev app CSS not being rebuilt when the typography styles change.
crisbeto
force-pushed
the
dev-app-typography-changes
branch
from
3deb100 to
b4f781b
Compare
devversion
approved these changes
Dec 23, 2018
devversion
added
pr: lgtm
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
Fixes the dev app CSS not being rebuilt when the typography styles change.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the dev app CSS not being rebuilt when the typography styles change.