Skip to content

refactor(radio): remove usage of mixinDisabled #14666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

refactor(radio): remove usage of mixinDisabled #14666

merged 1 commit into from
Jan 4, 2019

Conversation

swseverance
Copy link
Contributor

  • MatRadioGroup's disabled setter and getter methods already
    implement the same functionality that mixinDisabled provides,
    so mixinDisabled can safely be removed

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2018
devversion
devversion approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks

@swseverance
refactor(radio): remove usage of mixinDisabled
6cba060 
* `MatRadioGroup`'s `disabled` setter and getter methods already
  implement the same functionality that `mixinDisabled` provides,
  so `mixinDisabled` can safely be removed
devversion
devversion approved these changes Dec 29, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 29, 2018
@mmalerba mmalerba merged commit 390310d into angular:master Jan 4, 2019
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@swseverance @josephperrott
refactor(radio): remove usage of mixinDisabled (angular#14666)
81d94ae 
* `MatRadioGroup`'s `disabled` setter and getter methods already
  implement the same functionality that `mixinDisabled` provides,
  so `mixinDisabled` can safely be removed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swseverance @devversion @googlebot @mmalerba