Skip to content

fix(list): action list button outline not being reset on firefox #14693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2019
Merged

fix(list): action list button outline not being reset on firefox #14693

merged 1 commit into from
Jan 15, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 1, 2019

Fixes the extra focus outline that Firefox adds to buttons not being reset for the action list items.

For reference:
angular_material_-_mozilla_firefox_2019-01-01_21-38-37

@crisbeto
fix(list): action list button outline not being reset on firefox
a30dd4e 
Fixes the extra focus outline that Firefox adds to buttons not being reset for the action list items.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 1, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 1, 2019
jelbourn
jelbourn approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 8, 2019
@vivian-hu-zz vivian-hu-zz merged commit 73d0fb9 into angular:master Jan 15, 2019
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
@crisbeto
fix(list): action list button outline not being reset on firefox (ang…
a8059c2 
…ular#14693)

Fixes the extra focus outline that Firefox adds to buttons not being reset for the action list items.
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
@crisbeto
fix(list): action list button outline not being reset on firefox (ang…
4ebbb81 
…ular#14693)

Fixes the extra focus outline that Firefox adds to buttons not being reset for the action list items.
vivian-hu-zz pushed a commit that referenced this pull request Jan 18, 2019
@crisbeto
fix(list): action list button outline not being reset on firefox (#14693
6fd84dc 
)

Fixes the extra focus outline that Firefox adds to buttons not being reset for the action list items.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @vivian-hu-zz