Skip to content

build: run publish snapshots job with rbe #14867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

build: run publish snapshots job with rbe #14867

merged 1 commit into from
Jan 17, 2019

Conversation

devversion
Copy link
Member

No description provided.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 17, 2019
@devversion devversion requested a review from jelbourn as a code owner January 17, 2019 19:09
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 17, 2019
jelbourn
jelbourn approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 17, 2019
@ngbot
Copy link

ngbot bot commented Jan 17, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: bazel_build_test" is failing
    failure status "ci/circleci: tests_local_browsers" is failing
    failure status "ci/circleci: tests_browserstack" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@devversion devversion force-pushed the build/run-publish-snapshots-rbe branch from 1873aad to 2caecd0 Compare January 17, 2019 20:06
@devversion devversion mentioned this pull request Jan 17, 2019
Merged
@devversion devversion force-pushed the build/run-publish-snapshots-rbe branch from 2caecd0 to d02976d Compare January 17, 2019 20:40
@vivian-hu-zz vivian-hu-zz merged commit 4b35cad into angular:master Jan 17, 2019
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
@devversion
build: run publish snapshots job with rbe (angular#14867)
437ac59
vivian-hu-zz pushed a commit that referenced this pull request Jan 18, 2019
@devversion
build: run publish snapshots job with rbe (#14867)
d6852ca
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @vivian-hu-zz