fix(chips): focus lost if last chip is deleted #15344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
crisbeto
commented
Feb 28, 2019
crisbeto
force-pushed
the
15338/last-chip-focus
branch
from
29cee69 to
e933dbe
Compare
|
Hi all - would be great if this could be added to an upcoming release. Thank you |
crisbeto
force-pushed
the
15338/last-chip-focus
branch
from
e933dbe to
b8b7a3e
Compare
|
@crisbeto this passes presubmit but CircleCI is failing |
Fixes the user's focus being lost if they the last chip in a list. Fixes angular#15338.
crisbeto
force-pushed
the
15338/last-chip-focus
branch
from
b8b7a3e to
1fefc0c
Compare
|
Rebased and fixed the CI failure. Looks like a property in one of the fixture components got renamed. |
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
Fixes the user's focus being lost if they the last chip in a list. Fixes angular#15338.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the user's focus being lost if they delete the last chip in a list.
Fixes #15338.