Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 6, 2019

Bumps to the latest versions of stylelint and tslint, and fixes a new failure.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 6, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner March 6, 2019 22:25
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 6, 2019
Bumps to the latest versions of stylelint and tslint, and fixes a new failure.
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 27, 2019
@ngbot
Copy link

ngbot bot commented Mar 27, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba added the P2 The issue is important to a large percentage of users, with a workaround label Mar 27, 2019
@jelbourn jelbourn merged commit 1b4cb9b into angular:master Mar 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants