Skip to content

build: use npm packages from bazel #15497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

build: use npm packages from bazel #15497

wants to merge 9 commits into from

Conversation

devversion
Copy link
Member

@devversion devversion commented Mar 15, 2019 •
edited
Loading

TODO:

  • Material primary UMD bundle does not contain all secondary entry-points (potentially blocked)
    • Waiting for primary entry-point to no longer re-export all secondary entry-points?
  • When building release: ensure bazel uses clean output base?

Also blocked on angular/angular#29360

@devversion
build: bazel not working on windows workaround
196cc69 
Recently we updated our Bazel setup to Angular V8 beta. With that change
the Sass dependencies took precedence and now fetch the skylib repository
using the `git_repository` bazel rule. Unfortunately this rule does not always
work as expected in Windows (e.g. when used within Git Bash). Until Bazel
drops the dependency on bash, we should make sure that we fetch skylib
through the `http_archive` rule (which works on windows). Skylib will be
transitively brought in by the `rules_webtesting` repository.
@devversion
build: cdk bazel npm_package does not include stylesheets
933ed10
@devversion
build: create script to build bazel release packages
349bb3b
@devversion
build: update release script to use bazel packages
8f7a047
@devversion
build: run circleci tests with bazel release packages
b724b7d
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 15, 2019
@devversion devversion added the in progress This issue is currently in progress label Mar 15, 2019
@devversion devversion force-pushed the build/create-release-with-bazel branch from decc2ad to d4fd462 Compare March 15, 2019 19:33
@devversion devversion force-pushed the build/create-release-with-bazel branch from d4fd462 to 7a6a0ae Compare March 15, 2019 23:05
@devversion devversion added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Mar 18, 2019
@devversion devversion mentioned this pull request Mar 25, 2019
Merged
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@devversion
Copy link
Member Author

Closing in favor of a newer PR.

@devversion devversion closed this Sep 18, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
blocked This issue is blocked by some external factor, such as a prerequisite PR cla: yes PR author has agreed to Google's Contributor License Agreement in progress This issue is currently in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @mmalerba