Skip to content

feat(bottom-sheet): allow for scroll strategy to be configured #15535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

Allows for the scroll strategy of a bottom sheet to be changed.

Fixes #15533.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Mar 19, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner March 19, 2019 16:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 19, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 21, 2019
@ngbot
Copy link

ngbot bot commented Mar 21, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn
Copy link
Member

@crisbeto could you rebase?

Allows for the scroll strategy of a bottom sheet to be changed.

Fixes angular#15533.
@crisbeto
Copy link
Member Author

Rebased.

@crisbeto crisbeto force-pushed the 15533/bottom-sheet-scroll-strategy branch from eb8e411 to 0d4afe7 Compare May 13, 2019 15:44
@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019
@josephperrott josephperrott merged commit 6b2a390 into angular:master Jun 3, 2019
josephperrott pushed a commit that referenced this pull request Jun 10, 2019
Allows for the scroll strategy of a bottom sheet to be changed.

Fixes #15533.
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
…ar#15535)

Allows for the scroll strategy of a bottom sheet to be changed.

Fixes angular#15533.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mat-bottom-sheet scroll strategy
6 participants