Skip to content

fix(datepicker): don't set aria-haspopup if no datepicker is set #15554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2019
Merged

fix(datepicker): don't set aria-haspopup if no datepicker is set #15554

merged 1 commit into from
Aug 21, 2019

Conversation

crisbeto
Copy link
Member

Fixes the datepicker toggle and input setting aria-haspopup, even though they might not have a popup.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 20, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner March 20, 2019 19:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 20, 2019
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@crisbeto
fix(datepicker): don't set aria-haspopup if no datepicker is set
1454445 
Fixes the datepicker toggle and input setting `aria-haspopup`, even though they might not have a popup.
@crisbeto crisbeto force-pushed the datepicker-aria-has-popup branch from c43fb10 to 1454445 Compare May 30, 2019 06:26
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 12, 2019
@mmalerba mmalerba removed their assignment Aug 12, 2019
@andrewseguin andrewseguin merged commit 1b7dc89 into angular:master Aug 21, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
@crisbeto @andrewseguin
fix(datepicker): don't set aria-haspopup if no datepicker is set (#15554
f590dc6 
)

Fixes the datepicker toggle and input setting `aria-haspopup`, even though they might not have a popup.

(cherry picked from commit 1b7dc89)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @googlebot @mmalerba @andrewseguin