Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 21, 2019

Fixes errors that started being thrown by a couple of the expansion panel examples after we started lazy-loading the routes.

@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 21, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner March 21, 2019 18:19
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 21, 2019
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 21, 2019
@ngbot
Copy link

ngbot bot commented Mar 21, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label Mar 21, 2019
@devversion
Copy link
Member

Actually there seems to be a lint failure.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the lint error

Fixes errors in a couple of errors that started being thrown by a couple of the expansion panel examples after we started lazy-loading the routes.
@crisbeto crisbeto force-pushed the broken-accordion-examples branch from 9890841 to f827662 Compare March 21, 2019 21:14
@crisbeto
Copy link
Member Author

Fixed the lint issue.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 21, 2019
@andrewseguin andrewseguin merged commit 39d6c14 into angular:master Mar 22, 2019
andrewseguin pushed a commit that referenced this pull request Mar 25, 2019
Fixes errors in a couple of errors that started being thrown by a couple of the expansion panel examples after we started lazy-loading the routes.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants