build: do not ship schematic data typescript sources to npm #15597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the early stages of the schematics the upgrade data was stored in `.json` files. We switched these data files to TypeScript at some point, but didn't update the schematic-copy glob. Meaning that we currently ship TypeScript source files within the `data/` folder to NPM for the CDK and Material schematics.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Apr 4, 2019
In the early stages of the schematics the upgrade data was stored in `.json` files. We switched these data files to TypeScript at some point, but didn't update the schematic-copy glob. Meaning that we currently ship TypeScript source files within the `data/` folder to NPM for the CDK and Material schematics.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the early stages of the schematics the upgrade data was
stored in
.jsonfiles. We switched these data files to TypeScriptat some point, but didn't update the schematic-copy glob. Meaning
that we currently ship TypeScript source files within the
data/folderto NPM for the CDK and Material schematics.