Skip to content

Conversation

andrewseguin
Copy link
Contributor

This reverts commit bede74c.

Unfortunately this is failing a test internally that we were unaware of because it was in an already-failing state.

Will need to figure out more about why the async operation introduced here caused the test to fail. Perhaps they were working around the issue and that caused problem

@andrewseguin andrewseguin requested a review from crisbeto March 25, 2019 21:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 25, 2019
@andrewseguin andrewseguin requested a review from mmalerba March 25, 2019 21:49
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 25, 2019
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 25, 2019
@andrewseguin andrewseguin merged commit 8456ae6 into angular:master Mar 25, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants