build: staging script should ignore pre-commit hook #15612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if the caretaker stages a new release, but does not have the `git-clang-format` pre-commit hook configured properly (there is some additional configuration involved), the staging script will fail. In order to avoid these failures, we just ignore the pre-commit hook when a commit is created automatically by the release scripts. The release script only makes changes which conform with the clang-format's/ the project style guidelines.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
andrewseguin
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Apr 4, 2019
Currently if the caretaker stages a new release, but does not have the `git-clang-format` pre-commit hook configured properly (there is some additional configuration involved), the staging script will fail. In order to avoid these failures, we just ignore the pre-commit hook when a commit is created automatically by the release scripts. The release script only makes changes which conform with the clang-format's/ the project style guidelines.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the caretaker stages a new release but does not have the
git-clang-formatpre-commit hook configured properly (there is someadditional configuration involved), the staging script will fail.
In order to avoid these unexpected failures, we just ignore the pre-commit hook
when a commit is created automatically by the release scripts. The release script
only makes changes which conform with clang-format / the project's style
guidelines.