Skip to content

Conversation

devversion
Copy link
Member

@devversion devversion commented Mar 27, 2019

  • Switches us to the latest rbe_autoconfig Bazel rule. This allows us to remove the vendored base Bazel configuration. Also this drops the RBE "@angular" workspace dependency

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 27, 2019
@devversion devversion force-pushed the build/test-rbe-autoconfig branch 3 times, most recently from 7e2c919 to 336e5f5 Compare March 27, 2019 13:14
@devversion devversion force-pushed the build/test-rbe-autoconfig branch from 336e5f5 to ad2179d Compare March 27, 2019 13:29
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 27, 2019
@devversion devversion marked this pull request as ready for review March 27, 2019 13:41
@devversion devversion requested a review from jelbourn as a code owner March 27, 2019 13:41
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 27, 2019
@jelbourn jelbourn merged commit 495d1b5 into angular:master Mar 27, 2019
@ngbot
Copy link

ngbot bot commented Mar 27, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants