fix(datepicker): screen reader reading out role twice #15663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
mmalerba
approved these changes
Apr 1, 2019
|
@crisbeto this passes presubmit, just needs a rebase |
Currently the markup of the calendar is `div[role="grid"] > table > td[role="gridcell"]`. Because we've got both a `grid` and a `table`, NVDA ends up reading out something like "Dialog, table, table, 31st of March 2019, column X, row Y". These changes set the `table` to be a `presentation` role so that "table" is only read out once.
|
Rebased. |
crisbeto
force-pushed
the
datepicker-double-role
branch
from
c19c092 to
6e6e7cf
Compare
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
Currently the markup of the calendar is `div[role="grid"] > table > td[role="gridcell"]`. Because we've got both a `grid` and a `table`, NVDA ends up reading out something like "Dialog, table, table, 31st of March 2019, column X, row Y". These changes set the `table` to be a `presentation` role so that "table" is only read out once.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the markup of the calendar is
div[role="grid"] > table > td[role="gridcell"]. Because we've got both agridand atable, NVDA ends up reading out something like "Dialog, table, table, 31st of March 2019, column X, row Y". These changes set thetableto be apresentationrole so that "table" is only read out once.