Skip to content

prototype(slide-toggle): create prototype menu based on MDC Web #15893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

crisbeto
Copy link
Member

Creates a prototype of mat-slide-toggle that uses MDC web.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 24, 2019
@crisbeto crisbeto force-pushed the mdc-slide-toggle branch 6 times, most recently from aedec8c to 67db692 Compare April 24, 2019 19:08
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Apr 24, 2019
@crisbeto crisbeto marked this pull request as ready for review April 24, 2019 19:21
Creates a prototype of `mat-slide-toggle` that uses MDC web.
@crisbeto
Copy link
Member Author

All the feedback should be addressed now @mmalerba.

@mmalerba
Copy link
Contributor

Looks good, @crisbeto when you get a chance can you update the feature & size comparison sheet?

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 25, 2019
@mmalerba mmalerba merged commit b730ba8 into angular:master Apr 25, 2019
@mmalerba
Copy link
Contributor

related to #16248

RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
…lar#15893)

Creates a prototype of `mat-slide-toggle` that uses MDC web.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants