Skip to content

docs(text-field): change AutosizeMinRows to 1 #16021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2019
Merged

docs(text-field): change AutosizeMinRows to 1 #16021

merged 1 commit into from
May 14, 2019

Conversation

outofgamut
Copy link
Contributor

Change AutosizeMinRows from 2 to 1 so the text-field cdk docs example doesn't look weird at first glance.

Closes #15729

@outofgamut
docs(text-field): change autosize min rows to 1
93a1468 
Change AutosizeMinRows from 2 to 1 so the text-field cdk docs example doesn't look weird at first glance.

Closes angular#15729
@outofgamut outofgamut requested a review from jelbourn as a code owner May 14, 2019 05:29
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 14, 2019
@outofgamut outofgamut mentioned this pull request May 14, 2019
Closed
crisbeto
crisbeto approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels May 14, 2019
jelbourn
jelbourn approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 92dc089 into angular:master May 14, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@outofgamut @RudolfFrederiksen
docs(text-field): change text-field autosize example to minRows="1" (a…
7fbb5a8 
…ngular#16021)

Change AutosizeMinRows from 2 to 1 so the text-field cdk docs example doesn't look weird at first glance.

Closes angular#15729
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDK textfield example has too much vertical space
4 participants
@outofgamut @jelbourn @crisbeto @googlebot