Skip to content

Conversation

jelbourn
Copy link
Member

R: @tinayuangao
CC: @kara

The default generic type of EventEmitter is {}. If TS has strictNullChecks enabled, emitting null on such an emitter will cause a build error:

Type 'EventEmitter<{}>' is not assignable to type 'EventEmitter<null>'

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 26, 2016
@tinayuangao
Copy link
Contributor

LGTM

@jelbourn jelbourn merged commit 0174fa9 into angular:master Oct 27, 2016
@jelbourn jelbourn deleted the fix-keyboard-manager-ee-type branch September 13, 2017 04:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants