Skip to content

chore: fix new typescript errors with 3.5 #16386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

chore: fix new typescript errors with 3.5 #16386

merged 1 commit into from
Jul 9, 2019

Conversation

jelbourn
Copy link
Member

Google's TypeScript team is flushing out errors for 3.5. This
commit proactively addresses the three that popped up for us.

@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Jun 25, 2019
@jelbourn jelbourn requested a review from crisbeto June 25, 2019 22:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 25, 2019
crisbeto
crisbeto approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/cdk/tree/control/nested-tree-control.ts Outdated
// returns a `boolean` specifically in the context of `filter`, so we manually clarify that.
childrenNodes.pipe(take(1), filter(Boolean as () => boolean))
.subscribe(children => {
for (const c of children) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: c -> child

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel personally attacked

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 26, 2019
@jelbourn
chore: fix new typescript errors with 3.5
f3d0069 
Google's TypeScript team is flushing out errors for 3.5. This
commit proactively addresses the three that popped up for us.
@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful P2 The issue is important to a large percentage of users, with a workaround and removed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Jun 27, 2019
@jelbourn jelbourn merged commit d4ef125 into angular:master Jul 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @crisbeto @devversion @googlebot