Skip to content

refactor(schematics): allow subscription sharing on isHandset$ #16453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

refactor(schematics): allow subscription sharing on isHandset$ #16453

merged 1 commit into from
Jul 9, 2019

Conversation

jerome-nelson
Copy link
Contributor

Fixes #16434

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 4, 2019
devversion
devversion approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 4, 2019
@jelbourn jelbourn added target: patch This PR is targeted for the next patch release pr: merge safe labels Jul 8, 2019
@jelbourn jelbourn merged commit a6cdcfc into angular:master Jul 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isHandset$ should be a shared observable
5 participants
@jerome-nelson @crisbeto @devversion @jelbourn @googlebot