fix(tabs): only use aria-current on active links #16562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
P3
googlebot
added
the
cla: yes
crisbeto
reviewed
Jul 18, 2019
We previously set `aria-current` to either "true" or "false" for each `matTabLink`. This change now only applies the attribute to the active tab, omitting it for inactive tabs. Additionally, instead of setting true, we now set the attribute to "page", which specifically indicates that the item is a link that refers to the current page. Fixes angular#16557
jelbourn
force-pushed
the
nav-link-aria-current
branch
from
8720715
to
6464b73
Compare
|
Fixed the tests |
crisbeto
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jul 29, 2019
We previously set `aria-current` to either "true" or "false" for each `matTabLink`. This change now only applies the attribute to the active tab, omitting it for inactive tabs. Additionally, instead of setting true, we now set the attribute to "page", which specifically indicates that the item is a link that refers to the current page. Fixes #16557
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously set
aria-currentto either "true" or "false" for eachmatTabLink. This change now only applies the attribute to the activetab, omitting it for inactive tabs. Additionally, instead of setting
true, we now set the attribute to "page", which specifically indicates
that the item is a link that refers to the current page.
Fixes #16557