Skip to content

Conversation

tobiasschweizer
Copy link
Contributor

This PR puts the initialization of weekdays in a method that's called on init of the month view.

This is needed to update the month view correctly after a conversion to another calendar (dhlab-basel/JDNConvertibleCalendarDateAdapter#15 (comment)).

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 5, 2019
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 5, 2019
@tobiasschweizer
Copy link
Contributor Author

@crisbeto Thanks! Could we let @mmalerba have a look at it, too? I want to make sure that this PR resolves the issue I am having (dhlab-basel/JDNConvertibleCalendarDateAdapter#15 (comment)).

@mmalerba
Copy link
Contributor

mmalerba commented Aug 5, 2019

This looks like it should solve the issue. If you want to verify in your local setup:

  1. From your components directory run the following:
yarn
gulp {cdk,material}:build-release
(cd dist/releases ; npm pack ./{cdk,material})
  1. Then from your JDNConvertibleCalendarDateAdapter directory run the following:
yarn add /path/to/components/dist/releases/*.tgz

This will install your local changes to Angular Material in JDNConvertibleCalendarDateAdapter so you can test

@tobiasschweizer
Copy link
Contributor Author

@mmalerba I could verify locally that it works! Thanks a lot :-)

I will update JDNConvertibleCalendarDateAdapter to Angular 8 soon (currently still Angular 7).

@tobiasschweizer
Copy link
Contributor Author

@mmalerba Anything else needed for this PR to be merged?

@mmalerba
Copy link
Contributor

mmalerba commented Aug 6, 2019

Not from your end. It needs to go through our presubmit process to make sure it doesn't break internal apps or tests

@tobiasschweizer
Copy link
Contributor Author

I understand. Thx!

@mmalerba mmalerba merged commit 19453d4 into angular:master Aug 8, 2019
@tobiasschweizer tobiasschweizer deleted the tobiasschweizer-datepicker-weekdays branch August 12, 2019 07:10
mmalerba pushed a commit that referenced this pull request Aug 14, 2019
* feature (datepicker): update names of weekdays in month view on init

* feature (datepicker): make _initWeekdays a private method

(cherry picked from commit 19453d4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants