-
Notifications
You must be signed in to change notification settings - Fork 6.8k
DatePicker: update names of weekdays in month view on init #16689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatePicker: update names of weekdays in month view on init #16689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crisbeto Thanks! Could we let @mmalerba have a look at it, too? I want to make sure that this PR resolves the issue I am having (dhlab-basel/JDNConvertibleCalendarDateAdapter#15 (comment)). |
This looks like it should solve the issue. If you want to verify in your local setup:
This will install your local changes to Angular Material in JDNConvertibleCalendarDateAdapter so you can test |
@mmalerba I could verify locally that it works! Thanks a lot :-) I will update JDNConvertibleCalendarDateAdapter to Angular 8 soon (currently still Angular 7). |
@mmalerba Anything else needed for this PR to be merged? |
Not from your end. It needs to go through our presubmit process to make sure it doesn't break internal apps or tests |
I understand. Thx! |
* feature (datepicker): update names of weekdays in month view on init * feature (datepicker): make _initWeekdays a private method (cherry picked from commit 19453d4)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR puts the initialization of weekdays in a method that's called on init of the month view.
This is needed to update the month view correctly after a conversion to another calendar (dhlab-basel/JDNConvertibleCalendarDateAdapter#15 (comment)).