build: add API goldens for portal #16708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
portal-goldens-2-attack-of-the-clones
branch
from
325074d to
f83ae3e
Compare
Adds API goldens for the portal package and fixes some compilation errors that showed up when I was trying to generate it.
crisbeto
force-pushed
the
portal-goldens-2-attack-of-the-clones
branch
from
f83ae3e to
7bb4d01
Compare
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Aug 26, 2019
Adds API goldens for the portal package and fixes some compilation errors that showed up when I was trying to generate it. (cherry picked from commit 7c472f0)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds API goldens for the portal package and fixes some compilation errors that showed up when I was trying to generate it.
Note: this is another try at #16655 which caused some issues in G3. I've moved a few things around so that the directives don't collide.