feat(material-experimental): option to filter tab-group harness by selected tab label #16813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
approved these changes
Aug 19, 2019
| @@ -6,4 +6,6 @@ | |||
| * found in the LICENSE file at https://angular.io/license | |||
| */ | |||
|
|
|||
| export type TabGroupHarnessFilters = {}; | |||
| export type TabGroupHarnessFilters = { | |||
There was a problem hiding this comment.
Should this have a doc string?
There was a problem hiding this comment.
Not sure. The boilerplate and other harnesses don't have a doc string for these either.
devversion
force-pushed
the
feat/harness-tabs-filter-by-selected-tab
branch
from
9f4395c to
8d337ef
Compare
…lected tab Follow-up that addresses feedback from the original tab-group harness PR. See: angular#16728#discussion_r314819393
devversion
force-pushed
the
feat/harness-tabs-filter-by-selected-tab
branch
from
8d337ef to
e726ffe
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up that addresses feedback from the original tab-group
harness PR. See: #16728 (comment)