Skip to content

refactor(mdc-chips): Make MatChipTextControl publically available. #16820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2019
Merged

refactor(mdc-chips): Make MatChipTextControl publically available. #16820

merged 1 commit into from
Aug 21, 2019

Conversation

kor-k
Copy link
Contributor

@kor-k kor-k commented Aug 19, 2019 •
edited
Loading

Make the MatChipTextControl class available for implementation by other classes, so input fields other than input elements - eg. custom divs - can be used with mat-chip-grid (which currently assumes a matChipInputFor is provided).

@kor-k
refactor(mdc-chips): Make MatChipTextControl publically available.
46f1f4e 
Make the MatChipTextControl class available for implementation by other classes, so input fields other than <input> elements - eg. custom <div>s - can be used with mat-chip-grid (which currently assumes a matChipInputFor <input> is provided).
@kor-k kor-k requested a review from mmalerba as a code owner August 19, 2019 21:23
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 19, 2019
@mmalerba mmalerba requested a review from jelbourn August 19, 2019 23:04
@mmalerba
Copy link
Contributor

This seems reasonable to me. Question for @jelbourn should we also expose the src/material/chips version of `MatChipTextControl``?

jelbourn
jelbourn approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems reasonable to me. I wouldn't bother doing it for the current one unless someone requests it.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 20, 2019
@andrewseguin andrewseguin merged commit 2baa362 into angular:master Aug 21, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
@kor-k @andrewseguin
refactor(mdc-chips): Make MatChipTextControl publically available. (#…
6fa4c81 
…16820)

Make the MatChipTextControl class available for implementation by other classes, so input fields other than <input> elements - eg. custom <div>s - can be used with mat-chip-grid (which currently assumes a matChipInputFor <input> is provided).

(cherry picked from commit 2baa362)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kor-k @mmalerba @jelbourn @googlebot @andrewseguin