Skip to content

fix(ripple): allow pointer events on ripple; disable on checkbox ripple #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2016
Merged

fix(ripple): allow pointer events on ripple; disable on checkbox ripple #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bef0ae2
fix(ripple): allow pointer events on ripple; disable on checkbox ripple
andrewseguin Nov 1, 2016
84a4ccd
remove pointer event from radio
andrewseguin Nov 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/checkbox/checkbox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,4 +425,5 @@ md-checkbox {
bottom: -$md-checkbox-ripple-size;
border-radius: 50%;
z-index: 1;
pointer-events: none;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this on md-radio-ripple as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do, added another commit to include this

}
1 change: 0 additions & 1 deletion src/lib/core/ripple/_ripple.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ $md-ripple-foreground-default-color: rgba(0, 0, 0, 0.0588);
// "relative" so that the ripple divs it creates inside itself are correctly positioned.
[md-ripple] {
overflow: hidden;
pointer-events: none;
}

[md-ripple].md-ripple-unbounded {
Expand Down
1 change: 1 addition & 0 deletions src/lib/radio/radio.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,5 @@ md-radio-button {
bottom: -$md-radio-ripple-size;
border-radius: 50%;
z-index: 1;
pointer-events: none;
}