-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: remove unused gulp unit-test logic #16904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove unused gulp unit-test logic #16904
Conversation
Removes unused gulp unit-test watch logic. Tests are now executed and watched with Bazel (except on CI which still uses gulp for BrowserStack and Saucelabs)
6df7a22
to
4c78881
Compare
My problem with The Google version of the rule has a |
@jelbourn I'll take a stab on adding a local target. Regarding your issue with ibazel. I don't really understand how this would happen as per current implementation of ibazel and the karma rules, ibazel should just rebuild the tests and re-run in the exisiting browser. If this is an issue, then I probably didn't see it because for me, tests always run in chromium headless. did you explicitly opt into non-headless mode somehow? |
Nope, just e.g. ibazel run src/cdk/coercion:unit_tests |
This is something that we should probably ask @alexeagle to put on his backlog for providing automatically in the |
Closing this one. I'll resubmit this once we have the script for running local tests with Bazel. We have the targets already and it works with |
We can remove the unused code for `gulp test` and `gulp test:static`. The equivalent actions can be performed with Bazel and with the upcoming script that simplifies the testing workflow, there is no need for keeping this code in the codebase. All the concerns that have been mentioned in the old PR (angular#16904) have been resolved.
We can remove the unused code for `gulp test` and `gulp test:static`. The equivalent actions can be performed with Bazel and with the upcoming script that simplifies the testing workflow, there is no need for keeping this code in the codebase. All the concerns that have been mentioned in the old PR (angular#16904) have been resolved.
We can remove the unused code for `gulp test` and `gulp test:static`. The equivalent actions can be performed with Bazel and with the upcoming script that simplifies the testing workflow, there is no need for keeping this code in the codebase. All the concerns that have been mentioned in the old PR (#16904) have been resolved.
We can remove the unused code for `gulp test` and `gulp test:static`. The equivalent actions can be performed with Bazel and with the upcoming script that simplifies the testing workflow, there is no need for keeping this code in the codebase. All the concerns that have been mentioned in the old PR (angular#16904) have been resolved.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removes unused gulp unit-test watch logic. Tests are now
executed and watched with Bazel (except on CI which still uses
gulp for BrowserStack and Saucelabs)
Additionally while being at it, removes the gulp default task as the
recommended tasks are no longer available.