Skip to content

build: remove unused gulp unit-test logic #16904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

Removes unused gulp unit-test watch logic. Tests are now
executed and watched with Bazel (except on CI which still uses
gulp for BrowserStack and Saucelabs)

Additionally while being at it, removes the gulp default task as the
recommended tasks are no longer available.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 28, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 28, 2019
@devversion devversion marked this pull request as ready for review August 28, 2019 14:20
@devversion devversion requested a review from a team as a code owner August 28, 2019 14:20
Removes unused gulp unit-test watch logic. Tests are now
executed and watched with Bazel (except on CI which still uses
gulp for BrowserStack and Saucelabs)
@devversion devversion force-pushed the build/remove-unused-gulp-unit-test-logic branch from 6df7a22 to 4c78881 Compare August 28, 2019 20:10
@jelbourn
Copy link
Member

My problem with ibazel run approach right now is that it re-opens Chrome every time you make a change, and makes it your active window. In my case, it always pops open right over my IDE. It's super annoying and gets in the way of debugging.

The Google version of the rule has a _local suffixed target that doesn't open any browsers.

@devversion
Copy link
Member Author

@jelbourn I'll take a stab on adding a local target. Regarding your issue with ibazel. I don't really understand how this would happen as per current implementation of ibazel and the karma rules, ibazel should just rebuild the tests and re-run in the exisiting browser.

If this is an issue, then I probably didn't see it because for me, tests always run in chromium headless. did you explicitly opt into non-headless mode somehow?

@jelbourn
Copy link
Member

Nope, just e.g.

ibazel run src/cdk/coercion:unit_tests

@josephperrott
Copy link
Member

This is something that we should probably ask @alexeagle to put on his backlog for providing automatically in the karma_web_test and karma_web_test_suite rules

@josephperrott josephperrott removed their assignment Oct 15, 2019
@devversion
Copy link
Member Author

Closing this one. I'll resubmit this once we have the script for running local tests with Bazel. We have the targets already and it works with ibazel. All the concerns we talked about seem to have been addressed.

@devversion devversion closed this Dec 31, 2019
devversion added a commit to devversion/material2 that referenced this pull request Dec 31, 2019
We can remove the unused code for `gulp test` and `gulp test:static`.
The equivalent actions can be performed with Bazel and with the upcoming
script that simplifies the testing workflow, there is no need for
keeping this code in the codebase. All the concerns that have been
mentioned in the old PR (angular#16904) have been resolved.
devversion added a commit to devversion/material2 that referenced this pull request Jan 2, 2020
We can remove the unused code for `gulp test` and `gulp test:static`.
The equivalent actions can be performed with Bazel and with the upcoming
script that simplifies the testing workflow, there is no need for
keeping this code in the codebase. All the concerns that have been
mentioned in the old PR (angular#16904) have been resolved.
mmalerba pushed a commit that referenced this pull request Jan 7, 2020
We can remove the unused code for `gulp test` and `gulp test:static`.
The equivalent actions can be performed with Bazel and with the upcoming
script that simplifies the testing workflow, there is no need for
keeping this code in the codebase. All the concerns that have been
mentioned in the old PR (#16904) have been resolved.
yifange pushed a commit to yifange/components that referenced this pull request Jan 30, 2020
We can remove the unused code for `gulp test` and `gulp test:static`.
The equivalent actions can be performed with Bazel and with the upcoming
script that simplifies the testing workflow, there is no need for
keeping this code in the codebase. All the concerns that have been
mentioned in the old PR (angular#16904) have been resolved.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants