Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 3, 2019

It looks like something I overlooked when I first implemented the sortingDisabled flag. Currently it's set to true by default which means that sorting won't work unless users opt into it.

Fixes #16961.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Sep 3, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 3, 2019
It looks like something I overlooked when I first implemented the `sortingDisabled` flag. Currently it's set to `false` by default which means that sorting won't work unless users opt into it.

Fixes angular#16961.
@crisbeto crisbeto force-pushed the 16961/drag-drop-disabled-sorting branch from 6733e29 to c3a5760 Compare September 7, 2019 14:31
@jelbourn jelbourn merged commit 306e07c into angular:master Sep 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DropList created with DragDrop.createDropList is broken
3 participants