Skip to content

feat(material-experimental): add test harness for mdc-slider #16978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2019
Merged

feat(material-experimental): add test harness for mdc-slider #16978

merged 1 commit into from
Nov 5, 2019

Conversation

devversion
Copy link
Member

  • Adds a test harness for the mdc-slider that complies with the
    standard Angular Material slider test harness.

@devversion devversion added the target: patch This PR is targeted for the next patch release label Sep 4, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 4, 2019
devversion
devversion commented Sep 4, 2019
View reviewed changes
@devversion devversion marked this pull request as ready for review September 4, 2019 23:11
@devversion devversion added the needs: discussion Further discussion with the team is needed before proceeding label Sep 5, 2019
@devversion devversion force-pushed the feat/test-harness-mdc-slider branch from cc69ceb to d31c78b Compare September 5, 2019 18:22
devversion
devversion commented Sep 5, 2019
View reviewed changes
@devversion devversion added the blocked This issue is blocked by some external factor, such as a prerequisite PR label Sep 18, 2019
@devversion
Copy link
Member Author

Blocked on us figuring out a strategy to stabilize/await asynchronous tasks outside of the Angular zone. Miles and I already played with with some ideas, but in the meanwhile this is blocked.

@mmalerba mmalerba added this to the 9.0.0 milestone Sep 18, 2019
@mmalerba
Copy link
Contributor

Added to 9.0.0 milestone because we should figure out a solution for the zone issues before then

@mmalerba
Copy link
Contributor

There is now an open feature request in zonejs (angular/angular#32896) for the APIs we would need to more easily support waiting for tasks that are out of the NgZone

@mmalerba mmalerba added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Oct 1, 2019
@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround and removed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Oct 14, 2019
@devversion devversion force-pushed the feat/test-harness-mdc-slider branch from d31c78b to 15d7bb5 Compare October 15, 2019 18:11
@devversion devversion requested a review from mmalerba as a code owner October 15, 2019 18:11
@devversion devversion mentioned this pull request Oct 16, 2019
Merged
@devversion devversion added in progress and removed blocked This issue is blocked by some external factor, such as a prerequisite PR needs: discussion Further discussion with the team is needed before proceeding labels Oct 21, 2019
@devversion devversion force-pushed the feat/test-harness-mdc-slider branch from 15d7bb5 to c1dd19a Compare October 22, 2019 09:43
@devversion devversion force-pushed the feat/test-harness-mdc-slider branch from c1dd19a to 620414a Compare October 22, 2019 09:48
jelbourn
jelbourn reviewed Oct 24, 2019
View reviewed changes
@devversion
feat(material-experimental): add test harness for mdc-slider
312a6a3 
* Adds a test harness for the mdc-slider that complies with the
standard Angular Material slider test harness.
@devversion devversion force-pushed the feat/test-harness-mdc-slider branch from 620414a to 312a6a3 Compare October 24, 2019 20:09
@devversion
Copy link
Member Author

@jelbourn Done. Please have another look.

jelbourn
jelbourn approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 25, 2019
@mmalerba mmalerba merged commit 7cd314c into angular:master Nov 5, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @mmalerba @jelbourn @googlebot