feat(material-experimental): add test harness for mdc-slider #16978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
commented
Sep 4, 2019
devversion
added
the
needs: discussion
devversion
force-pushed
the
feat/test-harness-mdc-slider
branch
from
cc69ceb
to
d31c78b
Compare
devversion
commented
Sep 5, 2019
devversion
added
the
blocked
|
Blocked on us figuring out a strategy to stabilize/await asynchronous tasks outside of the Angular zone. Miles and I already played with with some ideas, but in the meanwhile this is blocked. |
|
Added to 9.0.0 milestone because we should figure out a solution for the zone issues before then |
|
There is now an open feature request in zonejs (angular/angular#32896) for the APIs we would need to more easily support waiting for tasks that are out of the |
mmalerba
added
the
P1
jelbourn
added
P2
devversion
force-pushed
the
feat/test-harness-mdc-slider
branch
from
d31c78b
to
15d7bb5
Compare
devversion
added
in progress
and removed
blocked
devversion
force-pushed
the
feat/test-harness-mdc-slider
branch
from
15d7bb5
to
c1dd19a
Compare
devversion
force-pushed
the
feat/test-harness-mdc-slider
branch
from
c1dd19a
to
620414a
Compare
jelbourn
reviewed
Oct 24, 2019
* Adds a test harness for the mdc-slider that complies with the standard Angular Material slider test harness.
devversion
force-pushed
the
feat/test-harness-mdc-slider
branch
from
620414a
to
312a6a3
Compare
|
@jelbourn Done. Please have another look. |
mmalerba
approved these changes
Oct 24, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standard Angular Material slider test harness.