feat(material-experimental/drawer): add harness for mat-drawer #17010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
drawer-harness
branch
from
e891133 to
c24c53f
Compare
mmalerba
requested changes
Sep 9, 2019
crisbeto
force-pushed
the
drawer-harness
branch
from
c24c53f to
e511b84
Compare
|
Addressed the feedback @mmalerba. |
mmalerba
approved these changes
Sep 9, 2019
Follow-up from angular#16695. Adds a separate harness for `mat-drawer` and has `mat-sidenav` inherit from it.
mmalerba
force-pushed
the
drawer-harness
branch
from
e511b84 to
bcf111e
Compare
mmalerba
changed the title
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Sep 24, 2019
…ar#17010) Follow-up from angular#16695. Adds a separate harness for `mat-drawer` and has `mat-sidenav` inherit from it. (cherry picked from commit 2001965)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #16695. Adds a separate harness for
mat-drawerand hasmat-sidenavinherit from it.