Skip to content

Conversation

crisbeto
Copy link
Member

Fixes an infinite loop in the build-release-packages task because an import from inside a package was referring to itself.

Fixes an infinite loop in the `build-release-packages` task because an import from inside a package was referring to itself.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 11, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 11, 2019
@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 11, 2019
@andrewseguin andrewseguin merged commit 96d914d into angular:master Sep 11, 2019
@ngbot
Copy link

ngbot bot commented Sep 11, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build_release_packages" is failing
    pending status "ci/circleci: api_golden_checks" is pending
    pending status "ci/circleci: bazel_build" is pending
    pending status "ci/circleci: e2e_tests" is pending
    pending status "ci/circleci: ivy_test" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 I think this won't happen with Bazel.

jelbourn pushed a commit to jelbourn/components that referenced this pull request Sep 24, 2019
Fixes an infinite loop in the `build-release-packages` task because an import from inside a package was referring to itself.

(cherry picked from commit 96d914d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants